Skip to content
Snippets Groups Projects
Commit b735de81 authored by attwad's avatar attwad
Browse files

Merge pull request #26 from oscii/master

Fix malformed packet when no arguments provided
parents ac978ceb 503b7cba
No related branches found
No related tags found
No related merge requests found
......@@ -97,6 +97,7 @@ class OscMessageBuilder(object):
# Write the address.
dgram += osc_types.write_string(self._address)
if not self._args:
dgram += osc_types.write_string(',')
return osc_message.OscMessage(dgram)
# Write the parameters.
......
......@@ -46,6 +46,13 @@ class TestOscMessageBuilder(unittest.TestCase):
builder.add_arg('this is not a float', builder.ARG_TYPE_FLOAT)
self.assertRaises(osc_message_builder.BuildError, builder.build)
def test_build_noarg_message(self):
msg = osc_message_builder.OscMessageBuilder(address='/SYNC').build()
# This reference message was generated with Cycling 74's Max software
# and then was intercepted with Wireshark
reference = bytearray.fromhex('2f53594e430000002c000000')
self.assertSequenceEqual(msg._dgram, reference)
if __name__ == "__main__":
unittest.main()
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment